Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set tooltip container on transaction table #824

Merged
merged 4 commits into from Dec 23, 2018

Conversation

@dated
Copy link
Contributor

commented Dec 21, 2018

Proposed changes

Partially solves #767 and replaces #822.

This sets the tooltip container to .TransactionTable and adds a property to WalletAddress, which allows to set a custom tooltip container.

tooltip

@j-a-m-l & @JeremiGendron can you confirm this works for you?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@j-a-m-l j-a-m-l self-requested a review Dec 21, 2018

@j-a-m-l

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2018

This doesn't solve the problem, @dated. Thanks anyway for trying it.

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2018

Which problem are we trying to solve? I am unable to replicate the issue described by Jeremi, but this solves the problem of the tooltip being shown above the app footer.

Imho adding an event listener to detect the scroll event and dismiss the tooltip is overkill.

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2018

To clarify, this PR fixes this behaviour:

@zillionn

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2018

Can't you listen for the scroll only when you show the tooltip and onScroll hide the tooltip and remove the listener?

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2018

If anything such behaviour should be added to the Akryum/v-tooltip package.

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2018

@j-a-m-l

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2018

@dated I missunderstood your intention: I though you were trying to fix that v-tooltip issue.

j-a-m-l and others added some commits Dec 21, 2018

@faustbrian faustbrian merged commit 9049cc8 into ArkEcosystem:develop Dec 23, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@dated dated deleted the dated:tooltip-container branch Dec 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.