Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use ticker instead of token for market chart #837

Merged
merged 3 commits into from Dec 23, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 21, 2018

Proposed changes

Use the market ticker instead of the token to fetch the chart data, as that is what it was supposed to be used for I guess 馃 It also adds a check if the response from cryptoCompare contains the right data, as the datasets property was not there if an incorrect ticker / token was used.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian merged commit beabe22 into develop Dec 23, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@ItsANameToo ItsANameToo deleted the fix/market-ticker branch Dec 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.