Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not update network config as it overwrites network changes #838

Merged
merged 1 commit into from Dec 23, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 21, 2018

Proposed changes

Networks got reloaded when you switched profiles, which reset any custom changes you made to it. This PR currently removes that behaviour, but I'm unsure what the use of fetching new network data was, so proposing two additional changes instead of simply removing it:

  1. we could call the updateNetworkConfig function the first time the app loads and we load the default networks from the config file (this is only done once).
  2. we could add a "refresh" button to the network modal in which you can see your network configs, which would overwrite any changes you made by fetching the latest config from a network peer. By doing it this way you will see the new settings and can adjust them to your liking, instead of having this happen in the background.

What do you think of the above solutions?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian merged commit 2d38bea into develop Dec 23, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@ItsANameToo ItsANameToo deleted the fix/network-reset branch Dec 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.