Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contact sorting #840

Merged
merged 4 commits into from Dec 23, 2018

Conversation

@kalgoop
Copy link
Contributor

commented Dec 22, 2018

Proposed changes

This resolves bug/problem discussed by @zillionn in #795
Contact are sorted based on name and then based on address. By this, ordering of contacts will remain fixed every time that contactsAll page is opened.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

kalgoop and others added some commits Dec 22, 2018

@faustbrian faustbrian merged commit 97ac1b8 into ArkEcosystem:develop Dec 23, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details
@kalgoop kalgoop referenced this pull request Jan 6, 2019
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.