Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use WalletAddress in the transactionShow modal #849

Merged
merged 1 commit into from Dec 23, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 23, 2018

Proposed changes

The modal to show transaction information simply showed the address of sender / recipient instead of (e.g.) vote / unvote like the transaction table does. This PR adds that same behaviour to the modal:

schermafbeelding 2018-12-23 om 13 48 55

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian merged commit 4ad76f2 into develop Dec 23, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the feat/wallet-address-modal branch Dec 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.