Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for tabular layout #852

Merged
merged 35 commits into from Jan 17, 2019

Conversation

@dated
Copy link
Contributor

commented Dec 23, 2018

Proposed changes

Implements #798.

layout

  • add WalletTable component
  • support sorting by name
  • extend for use on contacts page
  • add voted delegate
  • add loaders
  • add new contact button/row
  • add loading ledger

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

dated added some commits Dec 23, 2018

@boldninja

This comment has been minimized.

Copy link
Member

commented Dec 30, 2018

@dated can we in list view add a column for who you voting for from each account?

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Dec 30, 2018

That should be doable with a "i am voting for.." tooltip/icon. I'll try a few things.

@boldninja

This comment has been minimized.

Copy link
Member

commented Jan 9, 2019

@dated how is this looking? Can this take priority I'd like this in, in the next release we'll do. Will change tier to 1 for motivation.

dated added some commits Jan 11, 2019

@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

@dated is this still WIP?

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

yea, i need to finish the create contact button and loading ledger 😕

@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

no worries, just wanted to check 👌

@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Jan 15, 2019

@dated maybe this would be easier for the "Create" button?:

image

dated added some commits Jan 15, 2019

@dated dated changed the title [WIP] feat: support for tabular layout feat: support for tabular layout Jan 15, 2019

@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

I have some bad news 😞. Ledger wallets seem to be duplicating (i tested and doesn't happen on develop branch):

image

Also, getting spam and other errors in devtools:

image
image

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2019

hmm 😕 i'll try to debug the ledger situation but i don't have mine with me.

@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

True 😂 i briefly looked at that stuff. I did noticed a possible other issue when i looked at the code (after i found the issue). It fetches votes but only for normal wallets, not for the ledger wallets. I didn't properly test though as ledger was already playing up

dated and others added some commits Jan 16, 2019

@j-a-m-l

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2019

@dated great work!

Some suggestions:

  • Disable or remove the button to delete Ledger wallets
  • Change the pointer of the "Delete" column since it can't be used for sorting
  • Adapt it to narrow screens, currently it's hard to read because the background is transparent.
@dated

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2019

Disable or remove the button to delete Ledger wallets

The button is disabled already for ledger wallets and does not show the red hover color, I added a tooltip showing Ledger wallets cannot be deleted

Change the pointer of the "Delete" column since it can't be used for sorting

I changed the pointer to default and the text color stays the same on hover.

Adapt it to narrow screens, currently it's hard to read because the background is transparent.

Added the theme background to the respective sections (+ fixed text alignment in the create/import wallet buttons).

@j-a-m-l j-a-m-l merged commit 7977077 into ArkEcosystem:develop Jan 17, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@dated dated deleted the dated:tabular-layout branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.