Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unite router links of create/import buttons #854

Merged
merged 1 commit into from Dec 24, 2018

Conversation

@dated
Copy link
Contributor

commented Dec 23, 2018

Proposed changes

Instead of having two separate router links this PR refactors the wallet create / import buttons to have only one router link instead, increasing the clickable area and thus enhancing the UX of these components.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@dated dated changed the title misc: unite router links of create/import buttons refactor: unite router links of create/import buttons Dec 23, 2018

@faustbrian faustbrian merged commit 48c66c7 into ArkEcosystem:develop Dec 24, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@dated dated deleted the dated:wallet-buttons branch Dec 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.