Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: network modal name wrapping #868

Merged
merged 2 commits into from Dec 26, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 25, 2018

Proposed changes

Resolves #864

Wraps network names even if they have no spaces, and also truncates them if they are longer than a certain amount so the networks will not take up more than 3 rows of text in the modal.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@dated dated referenced this pull request Dec 25, 2018
3 of 3 tasks complete

@luciorubeens luciorubeens merged commit 70980d0 into develop Dec 26, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@luciorubeens luciorubeens deleted the fix/network-modal-name-wrapping branch Dec 26, 2018

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

fix: network modal name wrapping (ArkEcosystem#868)
* fix: wrap names in network modal

* fix: also truncate network name if longer than 20 chars

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

fix: network modal name wrapping (ArkEcosystem#868)
* fix: wrap names in network modal

* fix: also truncate network name if longer than 20 chars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.