Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): Change HKD symbol to HK$ #876

Merged
merged 1 commit into from Dec 27, 2018

Conversation

@JeremiGendron
Copy link
Contributor

commented Dec 27, 2018

It was previously the british pound's symbol in config/index.js

Fixes #875

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
fix(config): Change HKD symbol to HK$
It was previously the british pound's symbol in config/index.js

Fixes #875

@faustbrian faustbrian merged commit 48379ca into ArkEcosystem:develop Dec 27, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@JeremiGendron JeremiGendron deleted the JeremiGendron:fix/hkd-symbol branch Dec 27, 2018

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.