Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): Password visibility and Read more links #880

Merged
merged 2 commits into from Dec 30, 2018

Conversation

@JeremiGendron
Copy link
Contributor

commented Dec 28, 2018

Change the password-show/hide svg links to passphrase-x because
it renders correctly.
The Read more links now are only clickable on the Read more text.

Fixes: #871 #831

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
fix(misc): Password visibility and Read more links
Change the password-show/hide svg links to passphrase-x because
it renders correctly.
The Read more links now are only clickable on the Read more text

Fixes: #871 #831
@JeremiGendron JeremiGendron referenced this pull request Dec 30, 2018
3 of 12 tasks complete

@faustbrian faustbrian merged commit 12b3f05 into ArkEcosystem:develop Dec 30, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

fix(misc): Password visibility and Read more links (ArkEcosystem#880)
Change the password-show/hide svg links to passphrase-x because
it renders correctly.
The Read more links now are only clickable on the Read more text

Fixes: ArkEcosystem#871 ArkEcosystem#831

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

fix(misc): Password visibility and Read more links (ArkEcosystem#880)
Change the password-show/hide svg links to passphrase-x because
it renders correctly.
The Read more links now are only clickable on the Read more text

Fixes: ArkEcosystem#871 ArkEcosystem#831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.