Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shown placeholder message if wallet is a known wallet #881

Merged
merged 8 commits into from Dec 31, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 28, 2018

Proposed changes

This will make the wallet show an icon (waiting for the design from Oleg) when a wallet is a known wallet. The way it is set up makes sure that a known wallet will also get the icon if it has been imported as a contact with a different name, so if you have for example binance as a contact, it will still show the icon but with the contact name you have given it. The icon is used both in the transactions table and the wallet heading

schermafbeelding 2018-12-30 om 20 50 21

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@dated dated referenced this pull request Dec 28, 2018
2 of 3 tasks complete
@dated

This comment has been minimized.

Copy link
Contributor

commented Dec 30, 2018

If feasable we could even show a customized icon per address, e.g. the binance logo for binance. With a generic fallback icon if none is defined. Thoughts?

@faustbrian

This comment has been minimized.

Copy link
Contributor

commented Dec 30, 2018

I would keep it generic, it just adds overhead and no value if you use wallet specific icons.

ItsANameToo added some commits Dec 30, 2018

@ItsANameToo ItsANameToo changed the title [WIP] [DO NOT MERGE] feat: shown placeholder message if wallet is a known wallet feat: shown placeholder message if wallet is a known wallet Dec 30, 2018

@ItsANameToo

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 30, 2018

@faustbrian it's finished now

@faustbrian faustbrian merged commit 4085c45 into develop Dec 31, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the feat/known-wallet-indication branch Dec 31, 2018

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

feat: shown placeholder message if wallet is a known wallet (ArkEcosy…
…stem#881)

* feat: shown placeholder message if wallet is a known wallet

* feat: add verified address tooltip

* test: update tests to work with known wallets

* feat: add isknown placeholder to wallet heading too

* test: fix walletheadinginfo tests

* feat: show original known-wallet name if it differs from the currently used name for that wallet

* feat: add correct icon

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

feat: shown placeholder message if wallet is a known wallet (ArkEcosy…
…stem#881)

* feat: shown placeholder message if wallet is a known wallet

* feat: add verified address tooltip

* test: update tests to work with known wallets

* feat: add isknown placeholder to wallet heading too

* test: fix walletheadinginfo tests

* feat: show original known-wallet name if it differs from the currently used name for that wallet

* feat: add correct icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.