Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aip13 freeze #883

Merged
merged 4 commits into from Dec 30, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 29, 2018

Proposed changes

Some people reported that they could not fill in their passphrase when the wallet would get opened through an AIP13 link (based on currently ongoing arkland raffle). This issue was because feeStatistics could be undefined on a network. This PR sets a default feeStatistics property on the default networks that we supply in the config, and adds a synchronizer service that updates this statistic every 100 blocks.

Also resolves #856 since that was caused by the same issue

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

faustbrian added some commits Dec 30, 2018

@faustbrian faustbrian merged commit f24c37d into develop Dec 30, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the fix/aip13-freeze branch Dec 31, 2018

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

fix: aip13 freeze (ArkEcosystem#883)
* fix: set default feeStatistics values

* feat: add synchronizer for fetching fees from network

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

fix: aip13 freeze (ArkEcosystem#883)
* fix: set default feeStatistics values

* feat: add synchronizer for fetching fees from network

PHANTOM-DEV1 pushed a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 24, 2019

fix: aip13 freeze (ArkEcosystem#883)
* fix: set default feeStatistics values

* feat: add synchronizer for fetching fees from network
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.