Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: handle case where QR reader fails without error #888
The QR Reader can fail without throwing an error. In case the QR Reader is not successfully handled, (as noted in the issue #887) the app just freezes, and the user can't do anything except close the app. My change is to see if the QR Reader is successfully handled, if it is not then we throw an error and say loading is done after 10 seconds. This way the user gets some feedback and in turn can exit.
The linting passed. The unit tests there was 3 failures. But these same unit tests failed when I ran them on just the develop branch w/o my changes. So I don't believe my code changes introduced these.
I chose 10 seconds because when I was trying to load my camera and give permissions it seemed like 10 seconds was plenty since the camera was fast.
Also putting this here because at the bottom it wasn't showing up.
Types of changes