Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle case where QR reader fails without error #888

Merged
merged 2 commits into from Dec 30, 2018

Conversation

@ckhatri
Copy link
Contributor

commented Dec 29, 2018

Proposed changes

The QR Reader can fail without throwing an error. In case the QR Reader is not successfully handled, (as noted in the issue #887) the app just freezes, and the user can't do anything except close the app. My change is to see if the QR Reader is successfully handled, if it is not then we throw an error and say loading is done after 10 seconds. This way the user gets some feedback and in turn can exit.

Further comments

The linting passed. The unit tests there was 3 failures. But these same unit tests failed when I ran them on just the develop branch w/o my changes. So I don't believe my code changes introduced these.

I chose 10 seconds because when I was trying to load my camera and give permissions it seemed like 10 seconds was plenty since the camera was fast.

Also putting this here because at the bottom it wasn't showing up.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ckhatri ckhatri changed the title handle case where qr reader fails without error fixes #887 fix:handle case where qr reader fails without error fixes #887 Dec 29, 2018

@faustbrian faustbrian changed the title fix:handle case where qr reader fails without error fixes #887 fix:handle case where qr reader fails without error Dec 30, 2018

@faustbrian faustbrian changed the title fix:handle case where qr reader fails without error fix: handle case where QR reader fails without error Dec 30, 2018

@faustbrian faustbrian merged commit 8af445f into ArkEcosystem:develop Dec 30, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.