Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): Change the layout of the network Sidemenu #897

Merged
merged 2 commits into from Dec 31, 2018

Conversation

@JeremiGendron
Copy link
Contributor

commented Dec 30, 2018

Proposed changes

  • Flip the dropdown icon because peers are listed upwards
  • Change naming of labels
  • Add label to peer button
  • Remove "Peer:" prefix from the peer button
  • Add label for refresh button
  • Change naming of Connect your peer and Network overview

Ref: #892

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

image

JeremiGendron and others added some commits Dec 30, 2018

refactor(ui): Change the layout of the network Sidemenu
 - Flip the dropdown icon because peers are listed upwards
 - Change naming of labels
 - Add label to peer button
 - Remove "Peer:" prefix from the peer button
 - Add label for refresh button
 - Change naming of Connect your peer and Network overview

Ref: #892

@ItsANameToo ItsANameToo merged commit cc7359f into ArkEcosystem:develop Dec 31, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details
@ItsANameToo ItsANameToo referenced this pull request Dec 31, 2018
3 of 3 tasks complete

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

refactor(ui): Change the layout of the network Sidemenu (ArkEcosystem…
…#897)

- Flip the dropdown icon because peers are listed upwards
 - Change naming of labels
 - Add label to peer button
 - Remove "Peer:" prefix from the peer button
 - Add label for refresh button
 - Change naming of Connect your peer and Network overview

Ref: ArkEcosystem#892

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

refactor(ui): Change the layout of the network Sidemenu (ArkEcosystem…
…#897)

- Flip the dropdown icon because peers are listed upwards
 - Change naming of labels
 - Add label to peer button
 - Remove "Peer:" prefix from the peer button
 - Add label for refresh button
 - Change naming of Connect your peer and Network overview

Ref: ArkEcosystem#892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.