Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show delegate voters in vote modal #905

Merged
merged 1 commit into from Dec 31, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 30, 2018

Proposed changes

Adds the amount of voters of a delegate to the vote modal, fixes #901

Extra info: v1 endpoint will return a list of all the voters + their balances of a delegate, while v2 api will only show 100 and have pagination to show the rest. For small voters this will be 1 request like in v1, but if you want to filter out all the voters with less than 0.1 ark (as is currently done on the explorer with v1 api), you would need to make a lot of requests for delegates like biz_classic that have 5k voters. Maybe we need an api endpoint for this in v2 too? Or something to increase the limit so we aren't limited by 100 values.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian merged commit b162c33 into develop Dec 31, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the feat/delegate-voters branch Dec 31, 2018

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.