Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not reset inputcurrency to improve UX #909

Merged
merged 4 commits into from Dec 31, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 31, 2018

Proposed changes

Revert some changes (introduced in #882 ) made to the InputCurrency component as it acted weird.

Before: it would start the modal with showing an error for the Amount field, it would remove the 0 the first time you entered it into the field, and would reset to '' when you had a value like 0.00001 and removed the 1, see below screencap:
before

After:

after

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

ItsANameToo added some commits Dec 31, 2018

@dated

This comment has been minimized.

Copy link
Contributor

commented Dec 31, 2018

Good catch, didn't noticed that when i tested it. The reason for those changes were that the alternative currency amount does not get updated when you remove all input. Clearly there was somrthing wrong with how i did that, i'll have another look at it.

@ItsANameToo ItsANameToo merged commit 7f2963a into develop Dec 31, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@ItsANameToo ItsANameToo deleted the fix/input-currency branch Dec 31, 2018

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.