Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make time consistent in wallet #910

Merged
merged 7 commits into from Dec 31, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 31, 2018

Proposed changes

Makes time in wallet consistent with the one used on the explorer (and consistent in the wallet itself by using moment everywhere instead of vue's $d function). It also makes use of the "Multiple Locale Support" so it should show 12AM/PM for locales where that is the standard.

Resolves #908

Edit: added a dropdown in the profile where you can choose between default, 12h and 24h times. I’ve also removed the capitalize function from lodash as that would capitalize the first letter and make all others lowercase, which results in issues with store functions like setBip39Language as it would try to use setBip39language

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

ItsANameToo added some commits Dec 31, 2018

ItsANameToo and others added some commits Dec 31, 2018

@alexbarnsley alexbarnsley merged commit 124c7c1 into develop Dec 31, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@alexbarnsley alexbarnsley deleted the fix/consistent-time branch Dec 31, 2018

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.