Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update alternative currency when no input #912

Merged
merged 2 commits into from Dec 31, 2018

Conversation

@dated
Copy link
Contributor

commented Dec 31, 2018

Proposed changes

The alternative currency amount is not being set to 0 when there is no input.

@ItsANameToo this seems to work as originally intended, i am unable to reproduce the same bugs as in #882. Can you confirm?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ItsANameToo

This comment has been minimized.

Copy link
Collaborator

commented Dec 31, 2018

Seems to work 👍

@alexbarnsley alexbarnsley merged commit 0e3c633 into ArkEcosystem:develop Dec 31, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@dated dated deleted the dated:input-currency branch Dec 31, 2018

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.