Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input amount minimum #913

Merged
merged 4 commits into from Dec 31, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 31, 2018

Proposed changes

Changes the error showing the minimum allowed amount for a transfer to a fraction number instead of arktoshi1.00. Reasoning is that it's easier to compare 0.000000001 to the allowed 0.00000001 than arktoshi1.00:

schermafbeelding 2018-12-31 om 17 08 03

It also adds a space between crypto and amount to make it more readable:

schermafbeelding 2018-12-31 om 17 15 23

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

ItsANameToo and others added some commits Dec 31, 2018

@alexbarnsley alexbarnsley merged commit 1bba3f1 into develop Dec 31, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@alexbarnsley alexbarnsley deleted the fix/input-amount-minimum branch Dec 31, 2018

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.