Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: intro screens text content #916

Merged
merged 3 commits into from Jan 9, 2019

Conversation

@JeremiGendron
Copy link
Contributor

commented Dec 31, 2018

fix(intro): Your Duty (8, 9, 10)
fix(intro): Your Responsibility (11)
fix(intro): Your Turn (12)
fix(intro): Reformat Your responsibility to fit more text

Implement suggestions from justin on intro screen texts.

Ref: #891

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Dec 31, 2018

I've passed this on to @boldninja to take a look and have a read. For reference:

image

image

image

image

@codecov-io

This comment has been minimized.

Copy link

commented Jan 8, 2019

Codecov Report

Merging #916 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #916   +/-   ##
========================================
  Coverage    37.74%   37.74%           
========================================
  Files          194      194           
  Lines         4620     4620           
  Branches       887      885    -2     
========================================
  Hits          1744     1744           
  Misses        2761     2761           
  Partials       115      115
Impacted Files Coverage Δ
...rer/components/App/mobile/AppIntroScreenMobile.vue 0% <ø> (ø) ⬆️
src/renderer/components/App/AppIntroScreen.vue 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 366664e...92e480c. Read the comment docs.

STORAGE: 'You have the option of storing an encrypted copy of your passphrase locally. Please remember, your passphrase IS your account. If you choose this option and your computer dies, your account is lost forever.',
BACKUP: 'Always backup your passphrase and keep it in a safe place. The best practice is to write it down on thick paper and store it in a fireproof safe or save it on an encrypted flash drive.',
PASSPHRASE: 'Remember, anyone who has your passphrase can access your money. Never share your account with anyone and avoid storing it in accounts that are susceptible to hacking, such as cloud services.'
STORAGE: 'The passphrase of each wallet address is able to sign transactions and move funds. This means if your computer dies but you have your passphrase, you can still access your funds. The ARK Desktop Wallet has an additional feature that lets you set an encrypted password as well, for easier management. If your computer dies, you cannot use the encrypted password to access your funds from a different machine. You will need the passphrase.',

This comment has been minimized.

Copy link
@j-a-m-l

j-a-m-l Jan 8, 2019

Contributor

passphrase and encrypted password should be bold

This comment has been minimized.

Copy link
@JeremiGendron

JeremiGendron Jan 8, 2019

Author Contributor

can this be done in i18n directly, or split up into multiple segments?

This comment has been minimized.

Copy link
@j-a-m-l

j-a-m-l Jan 8, 2019

Contributor

You can use the i18n functional component (https://kazupon.github.io/vue-i18n/guide/interpolation.html#basic-usage), or split it up into multiple segments, as you prefer.

This comment has been minimized.

Copy link
@JeremiGendron

JeremiGendron Jan 8, 2019

Author Contributor

thanks! will do that today.

This comment has been minimized.

Copy link
@JeremiGendron

JeremiGendron Jan 8, 2019

Author Contributor

Wasn't sure whether to make bold all the occurrences, so only touched up the first paragraph as you've outlined.

04e3558#diff-92265712db23686ca615a58f84db7f52R72

JeremiGendron and others added some commits Dec 30, 2018

fix(intro): Various text content changes
fix(intro): Your Duty (8, 9, 10)

fix(intro): Your Responsibility (11)

fix(intro): Your Turn (12)

fix(intro): Reformat Your responsibility to fit more text
@j-a-m-l

j-a-m-l approved these changes Jan 9, 2019

@j-a-m-l j-a-m-l merged commit 926635f into ArkEcosystem:develop Jan 9, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.