Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Give hover class to WalletNew ButtonReload #920

Merged
merged 3 commits into from Jan 7, 2019

Conversation

@JeremiGendron
Copy link
Contributor

commented Jan 2, 2019

Proposed changes

  • Override default colorClass (provide bg-theme-button)
  • Add hover class (bg-theme-blue, text-grey-light)

Fixes: #874

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

fix button-reload-hover-color
fix button-reload-hover-color_dark

@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Jan 3, 2019

Could you get the refresh button text colour to match the next button please:

image

image

Also, the transition time seems to be slightly different when comparing those 2 buttons (on the Create Wallet page)

@JeremiGendron

This comment has been minimized.

Copy link
Contributor Author

commented Jan 3, 2019

Alright, I will do that now

JeremiGendron added some commits Jan 2, 2019

fix(ui): Give hover class to WalletNew ButtonReload
 - Override default colorClass (provide bg-theme-button)
 - Add hover class (bg-theme-blue, text-grey-light)

Fixes: #874
fix(ui) match the next button style, transition
 - Change text-grey-light to text-white
 - hover: box-shadow (button-blue-hover-shadow-definition)
 - transition: all .1s ease-in
@JeremiGendron

This comment has been minimized.

Copy link
Contributor Author

commented Jan 3, 2019

image

@zillionn

This comment has been minimized.

Copy link
Contributor

commented Jan 3, 2019

@JeremiGendron Can you also change the cursor, it's too dark :trollface:

@JeremiGendron

This comment has been minimized.

Copy link
Contributor Author

commented Jan 4, 2019

@zillionn my sick LXQT desktop environment is too much?

@codecov-io

This comment has been minimized.

Copy link

commented Jan 7, 2019

Codecov Report

Merging #920 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #920   +/-   ##
========================================
  Coverage    37.82%   37.82%           
========================================
  Files          193      193           
  Lines         4606     4606           
  Branches       883      883           
========================================
  Hits          1742     1742           
  Misses        2749     2749           
  Partials       115      115
Impacted Files Coverage Δ
src/renderer/pages/Wallet/WalletNew.vue 36.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33de495...5835fb9. Read the comment docs.

@alexbarnsley alexbarnsley merged commit 1f83680 into ArkEcosystem:develop Jan 7, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@JeremiGendron JeremiGendron deleted the JeremiGendron:fix/button-reload-hover-color branch Jan 7, 2019

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.