New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send transfer transaction to current peer #922

Merged
merged 2 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@alexbarnsley
Copy link
Member

alexbarnsley commented Jan 3, 2019

Proposed changes

A bug was introduced when adding/upgrading the URI system whereby every transfer transaction would be sent to a new peer. This checks to make sure the wallet being sent from is on a different network to the current profile.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian merged commit 120bc59 into develop Jan 3, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the fix/send-tx-current-peer branch Jan 3, 2019

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

fix: send transfer transaction to current peer (ArkEcosystem#922)
* refactor: rename wallet override variable

* fix: only get new peer if on different network

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

fix: send transfer transaction to current peer (ArkEcosystem#922)
* refactor: rename wallet override variable

* fix: only get new peer if on different network
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment