New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send all confirmation #924

Merged
merged 3 commits into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@alexbarnsley
Copy link
Member

alexbarnsley commented Jan 4, 2019

Proposed changes

Send all confirmation to make sure people don't "fat finger" the switch and lose their tokens.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian merged commit f3dc59a into develop Jan 4, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the feat/send-all-confirmation branch Jan 4, 2019

@dated dated referenced this pull request Jan 6, 2019

Open

[WIP] feat: different display for transaction sent to self #934

3 of 4 tasks complete

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

feat: send all confirmation (ArkEcosystem#924)
* refactor: input and button switch

* feat: portal target prop for confirmation modal

* feat: confirm send all popup

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

feat: send all confirmation (ArkEcosystem#924)
* refactor: input and button switch

* feat: portal target prop for confirmation modal

* feat: confirm send all popup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment