New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh all ledger wallets, not just cache #926

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@alexbarnsley
Copy link
Member

alexbarnsley commented Jan 4, 2019

Proposed changes

In order to save on duplicate requests, the ledger store deals with refreshing wallet information. However the problem was that it was only refreshing the last wallet because it was basing it on the cache.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@alexbarnsley alexbarnsley requested review from luciorubeens and faustbrian Jan 4, 2019

@faustbrian faustbrian merged commit 464a460 into develop Jan 4, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the fix/ledger-cached-refresh branch Jan 4, 2019

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment