Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: transaction helper props in store getters #927

Merged
merged 3 commits into from Jan 7, 2019

Conversation

@dated
Copy link
Contributor

commented Jan 4, 2019

Proposed changes

Solves #923 by adding the isSender, isReceiver and totalAmount helper properties also to the transactions returned by the store getters.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

dated added some commits Jan 4, 2019

@alexbarnsley alexbarnsley merged commit 031f2d2 into ArkEcosystem:develop Jan 7, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@dated dated deleted the dated:transactions branch Jan 7, 2019

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.