Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: set default fees on transfer screen so send all properly works #930
Reported to me in slack by tk0n: the send-all button didn't take into account the 0.1 fee on v1 networks. After looking into it, this seems to be caused by the fees being set on submit, instead of when the form is created. So while using the form, it defaults to a fee of 0 if you haven't touched the inputFee component (which is not available on v1) and will incorrectly calculated the amount you can send. This also seems to be an issue on v2 networks if you don't interact with the inputFee component as it will also default to 0 in that case.
Types of changes
So looking at this, an e2e test will not be the best approach since it will require a whole workflow to get to the proper page; meaning that half the wallet will be tested just to get to that transaction screen.
Unit test should work, but the