Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Clarify custom peer disconnection #939

Merged
merged 7 commits into from Jan 7, 2019

Conversation

@JeremiGendron
Copy link
Contributor

commented Jan 6, 2019

Proposed changes

  • Implement v-if/else-if/else switch for peer/custom/disconnecting
  • Provide "Disconnect from peer" instead of "Connect to best" when connected to custom peer
  • Automatically refresh (and show through refresh button rotation) when user disconnects from peer
  • Use the cross svg with matching styling to the refresh button
  • hover:bg-theme-option-button-hover hover:text-grey-light

Looks and feels very nice. Planning to add more functionality to the custom peer interface as mentionned in the Ref below. I think we should provide a timeout window for reconnecting when a custom peer disconnects which the user can manually terminate (alongside the presented disconnect button).

Fixes: #938
Ref: #981

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

image

image

After click
image

After disconnect
image

feat(ux): Clarify custom peer disconnection
 - Implement v-if/else-if/else switch for peer/custom/disconnecting
 - Provide "Disconnect from peer" instead of "Connect to best" when connected to custom peer
 - Automatically refresh (and show through refresh button rotation) when user disconnects from peer
 - Use the cross svg with matching styling to the refresh button
 - hover:bg-theme-option-button-hover hover:text-grey-light
Looks and feels very nice. Planning to add more functionality to the custom peer interface as mentionned in the Ref below. I think we should provide a timeout window for reconnecting when a custom peer disconnects which the user can manually terminate (alongside the presented disconnect button).

Fixes: #938
Ref: #981

faustbrian added some commits Jan 7, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jan 7, 2019

Codecov Report

Merging #939 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #939   +/-   ##
========================================
  Coverage    37.83%   37.83%           
========================================
  Files          193      193           
  Lines         4610     4610           
  Branches       884      884           
========================================
  Hits          1744     1744           
  Misses        2751     2751           
  Partials       115      115
Impacted Files Coverage Δ
src/renderer/pages/Wallet/WalletNew.vue 36.14% <ø> (ø) ⬆️
...nents/App/AppSidemenu/AppSidemenuNetworkStatus.vue 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a591b38...3a9b978. Read the comment docs.

@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

I think it looks good. My only tweak would be to add a hover-over to the reload button. Possibly to match the reload button hover on the create wallet page, but the dark mode colour 🤔

@JeremiGendron

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2019

alright, I'll do that now @alexbarnsley

@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

thanks @JeremiGendron 👌

@JeremiGendron

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2019

And light theme
image

@ItsANameToo

This comment has been minimized.

Copy link
Collaborator

commented Jan 7, 2019

@JeremiGendron just a note, it's better if you leave out the stuff between brackets after the commit keywords like feat and refactor, since they don't add any value in this repo. It's used in core to denote the package that is worked on, but here we don't have different packages. So don't use feat(ux):, just keep it at feat:

@JeremiGendron

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2019

@ItsANameToo got it, thanks!

@alexbarnsley alexbarnsley changed the title feat(ux): Clarify custom peer disconnection feat: Clarify custom peer disconnection Jan 7, 2019

@@ -196,6 +224,7 @@ export default {
methods: {
async refreshPeer () {
console.log('clicked')

This comment has been minimized.

Copy link
@alexbarnsley
@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

Just a debug line that needs removing then can be merged 👌

@alexbarnsley alexbarnsley merged commit 9f4d284 into ArkEcosystem:develop Jan 7, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@JeremiGendron JeremiGendron deleted the JeremiGendron:feat/disconnect-custom-peer branch Jan 7, 2019

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.