New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: get ledger address & public key together #941

merged 5 commits into from Jan 7, 2019


None yet
2 participants
Copy link

alexbarnsley commented Jan 6, 2019

Proposed changes

This includes some refactor as the ledger transport layer returns both public key and address together. It also reduces a ledger call when reloading wallets, hopefully speeding it up marginally.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Test (adding missing tests or fixing existing tests)


  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

alexbarnsley and others added some commits Jan 6, 2019

@faustbrian faustbrian merged commit e498433 into develop Jan 7, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!

@faustbrian faustbrian deleted the fix/speed-up-ledger branch Jan 7, 2019

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

refactor: get ledger address & public key together (ArkEcosystem#941)
* refactor: ledger get both address & public key

* fix: check transport before closing

* test: refactor ledger & add getWallet tests

* test: fix failing ledger service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment