Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ledger throw errors #943

Merged
merged 4 commits into from Jan 7, 2019

Conversation

@alexbarnsley
Copy link
Member

commented Jan 7, 2019

Proposed changes

Also fixes issue with accountIndex validation

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

alexbarnsley added some commits Jan 7, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jan 7, 2019

Codecov Report

Merging #943 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #943      +/-   ##
===========================================
+ Coverage     37.8%   37.83%   +0.02%     
===========================================
  Files          193      193              
  Lines         4610     4610              
  Branches       886      884       -2     
===========================================
+ Hits          1743     1744       +1     
+ Misses        2752     2751       -1     
  Partials       115      115
Impacted Files Coverage Δ
src/renderer/store/modules/ledger.js 59.6% <100%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27dd194...d3b5046. Read the comment docs.

@alexbarnsley

This comment has been minimized.

Copy link
Member Author

commented Jan 7, 2019

thanks @luciorubeens :lala:

@alexbarnsley alexbarnsley merged commit a591b38 into develop Jan 7, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@alexbarnsley alexbarnsley deleted the refactor/ledger-throw-errors branch Jan 7, 2019

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

refactor: ledger throw errors (ArkEcosystem#943)
* fix: accountIndex type check

* refactor: throw errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.