Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not display the not-voting icon before knowing if the wallet is voting #950

Merged
merged 5 commits into from Jan 14, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Jan 9, 2019

Proposed changes

When navigating to 1 wallet, or switching from 1 to other, the orange dot that warns about that the wallet is not voting, is displayed even when the wallet is voting while fetching data.

That was very annoying, and this PR changes the behaviour and it doesn't show it until checking on the server that the wallet is not voting.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

commented Jan 11, 2019

Codecov Report

Merging #950 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #950      +/-   ##
===========================================
- Coverage    37.95%   37.93%   -0.02%     
===========================================
  Files          194      194              
  Lines         4624     4626       +2     
  Branches       889      889              
===========================================
  Hits          1755     1755              
- Misses        2756     2758       +2     
  Partials       113      113
Impacted Files Coverage Δ
...llet/WalletHeading/WalletHeadingPrimaryActions.vue 46.66% <ø> (-7.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a7053a...da857bd. Read the comment docs.

Update src/renderer/components/Wallet/WalletHeading/WalletHeadingPrim…
…aryActions.vue

Co-Authored-By: j-a-m-l <j-a-m-l@users.noreply.github.com>

Suggestion was committed

@luciorubeens

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

Sorry, the arrow function that I suggested broke the component context (this). I just pushed the fix.

@luciorubeens luciorubeens merged commit 4c51899 into develop Jan 14, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@luciorubeens luciorubeens deleted the do-not-warn-about-voting-always branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.