Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change delegate voting banner if wallet is not owned #953

Merged
merged 1 commit into from Jan 14, 2019

Conversation

@dated
Copy link
Contributor

commented Jan 11, 2019

Proposed changes

The vote banner in the delegates tab shows the unvote button even if the wallet is not owned by the user, i.e. it has not been imported as such. This PR hides the button and changes the text from You to This wallet.

Owned:
image

Not owned:
image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@j-a-m-l j-a-m-l self-requested a review Jan 14, 2019

@j-a-m-l j-a-m-l changed the title fix: hide unvote button if wallet is not owned fix: change delegate voting banner if wallet is not owned Jan 14, 2019

@j-a-m-l j-a-m-l merged commit 6aaff0f into ArkEcosystem:develop Jan 14, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@dated dated deleted the dated:unvote-banner branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.