Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: check if contact address or name is already present #955
Adds validation to the new contact form, disabling the first steps
Types of changes
The current implementation doesn't allow duplicating wallets and contacts. Even in your PR and error toast is triggered after clicking on "Done". It would be better to display those messages on the form and disallow the buttons.
Keep in mind that adding an existing wallet as a contact doesn't add any value and it promotes confusing behaviours. For instance: which labels would be used to display it on the transaction table?
I like your idea of showing a different message if the contact address already exists as a wallet, but: