Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add Italian language #957

Merged
merged 21 commits into from Mar 13, 2019

Conversation

@danielstc
Copy link
Contributor

commented Jan 12, 2019

Proposed changes

Add the Italian language according to the guidelines of the README.md

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

danielstc added some commits Jan 12, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jan 12, 2019

Codecov Report

Merging #957 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #957   +/-   ##
========================================
  Coverage    41.19%   41.19%           
========================================
  Files          213      213           
  Lines         5443     5443           
  Branches      1064     1064           
========================================
  Hits          2242     2242           
  Misses        3079     3079           
  Partials       122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2dbd52...5c7cd9b. Read the comment docs.

@j-a-m-l j-a-m-l changed the title [Lang] Add Italian language misc: add Italian language Jan 21, 2019

j-a-m-l added some commits Jan 21, 2019

@j-a-m-l

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2019

@danielstc We have changed the introductory screens, and now users can select the language at the beginning. Since we have included new features, some texts have been added, so you probably wouldn't need to make big changes to your translation.

Related to that, we have added a tool to check what transactions are missing. You can see the instructions on the develop branch: https://github.com/ArkEcosystem/desktop-wallet#translations

If you have any doubt, please contact me. Your translation would be released on the new version 🎉

@danielstc

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

@j-a-m-l Ok. I will make changes in the next days.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

@danielstc Your pull request needs some changes. Please wait for a comment from one of our developers for more information.

Update it-IT.js
latest changes
@danielstc

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2019

@j-a-m-l updated

danielstc added some commits Mar 9, 2019

danielstc added some commits Mar 11, 2019

@j-a-m-l
Copy link
Contributor

left a comment

Good work @danielstc. I've added some comments on translations that look pending because they coincide with English. Please, review them.

src/renderer/i18n/locales/it-IT.js Outdated Show resolved Hide resolved
src/renderer/i18n/locales/it-IT.js Show resolved Hide resolved
src/renderer/i18n/locales/it-IT.js Outdated Show resolved Hide resolved
src/renderer/i18n/locales/it-IT.js Show resolved Hide resolved
src/renderer/i18n/locales/it-IT.js Outdated Show resolved Hide resolved
src/renderer/i18n/locales/it-IT.js Outdated Show resolved Hide resolved
src/renderer/i18n/locales/it-IT.js Show resolved Hide resolved
src/renderer/i18n/locales/it-IT.js Outdated Show resolved Hide resolved
src/renderer/i18n/locales/it-IT.js Outdated Show resolved Hide resolved
src/renderer/i18n/locales/it-IT.js Outdated Show resolved Hide resolved
@danielstc

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

@j-a-m-l reviewed your comments. How do I proceed now? Do I have to make changes or wait for your instructions?

Update it-IT.js
review changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

The ci/circleci: test-node-11 job is failing as of cd45b5902339053a6fcd16f28c94258bce3d050e. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

The ci/circleci: test-node-11 job is failing as of 513dccfe65faad6ab5f3b6d7a79e43cc1b412b95. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

danielstc added some commits Mar 12, 2019

Update en-US.js
Language selector in original language
Update it-IT.js
typo fix
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@j-a-m-l j-a-m-l merged commit 466092f into ArkEcosystem:develop Mar 13, 2019

1 check failed

ci/circleci: test-node-11 Your tests failed on CircleCI
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

Your pull request has been merged and marked as tier 3. It will earn you $25 USD.

@danielstc danielstc deleted the danielstc:it-IT branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.