Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load all networks correctly #959

merged 6 commits into from Jan 14, 2019


Copy link

commented Jan 14, 2019

Proposed changes

I seemed to have an intermittent issue where all my custom networks were disappearing. This I believe was caused by 2 separate things. "Loading" the network data too early, before vuex was ready. And also the local getter was trying to access the root (getters['network/all']).

In case this has caused issues in other wallets, I've added a temporary fix to make sure all has all of the custom networks on load.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Test (adding missing tests or fixing existing tests)


  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

This comment has been minimized.

Copy link

commented Jan 14, 2019

Codecov Report

Merging #959 into develop will increase coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #959      +/-   ##
+ Coverage    37.67%   37.95%   +0.27%     
  Files          194      194              
  Lines         4629     4624       -5     
  Branches       887      889       +2     
+ Hits          1744     1755      +11     
+ Misses        2770     2756      -14     
+ Partials       115      113       -2
Impacted Files Coverage Δ
src/renderer/App.vue 0% <ø> (ø) ⬆️
src/renderer/store/modules/network.js 34.54% <100%> (+21.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aaff0f...0ee94c5. Read the comment docs.

@alexbarnsley alexbarnsley changed the title [WIP] fix: load all networks correctly fix: load all networks correctly Jan 14, 2019

@alexbarnsley alexbarnsley requested review from ItsANameToo, j-a-m-l and luciorubeens and removed request for ItsANameToo and j-a-m-l Jan 14, 2019

@faustbrian faustbrian merged commit 0a7053a into develop Jan 14, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!

@ItsANameToo ItsANameToo deleted the fix/all-networks branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.