Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address truncation in transaction table #960

Merged
merged 2 commits into from Jan 16, 2019

Conversation

@luciorubeens
Copy link
Member

commented Jan 14, 2019

Proposed changes

Apply style directly to the WalletAddress, since the .truncate utility needs a fixed width this will work as expected.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Jan 15, 2019

Truncate looks good now, but seeing a weird tooltip issue 🤔

image

@alexbarnsley alexbarnsley referenced this pull request Jan 15, 2019
4 of 12 tasks complete
@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

I'll merge this now and take a look at the tooltip issue separately, since this was an issue prior to your changes.

@codecov-io

This comment has been minimized.

Copy link

commented Jan 16, 2019

Codecov Report

Merging #960 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #960   +/-   ##
========================================
  Coverage    38.81%   38.81%           
========================================
  Files          196      196           
  Lines         4833     4833           
  Branches       942      945    +3     
========================================
  Hits          1876     1876           
  Misses        2838     2838           
  Partials       119      119
Impacted Files Coverage Δ
src/renderer/components/Wallet/WalletAddress.vue 53.84% <ø> (ø) ⬆️
...nderer/components/Transaction/TransactionTable.vue 18.18% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d851c94...e96c624. Read the comment docs.

@alexbarnsley alexbarnsley merged commit 0a85da7 into develop Jan 16, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@alexbarnsley alexbarnsley added Type: Bugfix and removed Type: Bug labels Jan 16, 2019

@alexbarnsley alexbarnsley deleted the feat/address-truncation branch Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.