Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update changelly widget #961

Merged
merged 4 commits into from Jan 15, 2019

Conversation

@luciorubeens
Copy link
Member

commented Jan 15, 2019

Proposed changes

Update the changelly widget to the new version: https://changelly.com/widget-settings

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
@codecov-io

This comment has been minimized.

Copy link

commented Jan 15, 2019

Codecov Report

Merging #961 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #961      +/-   ##
==========================================
+ Coverage    37.58%   37.6%   +0.01%     
==========================================
  Files          196     196              
  Lines         4709    4707       -2     
  Branches       905     905              
==========================================
  Hits          1770    1770              
+ Misses        2820    2818       -2     
  Partials       119     119
Impacted Files Coverage Δ
...omponents/Wallet/WalletExchange/WalletExchange.vue 8.33% <ø> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b785613...ad4e91a. Read the comment docs.

@alexbarnsley
Copy link
Member

left a comment

Just one possible change - remove EXCHANGE config if not used elsewhere

@luciorubeens

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2019

@alexbarnsley True that. Done!

@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Jan 15, 2019

bootiful

@alexbarnsley alexbarnsley merged commit f14fa58 into develop Jan 15, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@alexbarnsley alexbarnsley deleted the feat/changelly-widget branch Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.