Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close vote modal on confirm #963

Merged
merged 3 commits into from Jan 15, 2019

Conversation

@alexbarnsley
Copy link
Member

commented Jan 15, 2019

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@alexbarnsley alexbarnsley requested a review from luciorubeens Jan 15, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jan 15, 2019

Codecov Report

Merging #963 into develop will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #963      +/-   ##
===========================================
+ Coverage     37.6%   37.68%   +0.08%     
===========================================
  Files          196      196              
  Lines         4707     4707              
  Branches       908      905       -3     
===========================================
+ Hits          1770     1774       +4     
+ Misses        2818     2815       -3     
+ Partials       119      118       -1
Impacted Files Coverage Δ
...ponents/Wallet/WalletDelegates/WalletDelegates.vue 48.93% <ø> (ø) ⬆️
src/renderer/store/modules/peer.js 71.29% <0%> (+1.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f14fa58...1ee526c. Read the comment docs.

@luciorubeens luciorubeens merged commit f2ddaed into develop Jan 15, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@luciorubeens luciorubeens deleted the fix/broadcast-vote-close branch Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.