Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: computed voted delegate name #964

Merged
merged 6 commits into from Jan 15, 2019

Conversation

@alexbarnsley
Copy link
Member

commented Jan 15, 2019

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
@codecov-io

This comment has been minimized.

Copy link

commented Jan 15, 2019

Codecov Report

Merging #964 into develop will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #964      +/-   ##
===========================================
- Coverage    37.36%   37.29%   -0.07%     
===========================================
  Files          196      196              
  Lines         4742     4740       -2     
  Branches       920      920              
===========================================
- Hits          1772     1768       -4     
- Misses        2851     2853       +2     
  Partials       119      119
Impacted Files Coverage Δ
src/renderer/components/Wallet/WalletAddress.vue 53.84% <ø> (-6.87%) ⬇️
src/renderer/store/modules/session.js 30% <0%> (-1.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e54607...725a311. Read the comment docs.

luciorubeens and others added some commits Jan 15, 2019

@alexbarnsley

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2019

sorry @luciorubeens, i just accidentally dismissed your review. I was adding tests for this

@luciorubeens luciorubeens merged commit 16fb96a into develop Jan 15, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details
@luciorubeens

This comment has been minimized.

Copy link
Member

commented Jan 15, 2019

@alexbarnsley :susp:

@luciorubeens luciorubeens deleted the fix/delegate-vote branch Jan 15, 2019

@alexbarnsley

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2019

If @ItsANameToo hadn't distracted me I'd have pushed before 😭

@ItsANameToo

This comment has been minimized.

Copy link
Collaborator

commented Jan 15, 2019

fake news

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.