Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: display app version in the window title #965

Merged
merged 3 commits into from Jan 15, 2019

Conversation

@luciorubeens
Copy link
Member

commented Jan 15, 2019

Proposed changes

Change the release filename, add version to the window title and fixes the productName.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

@luciorubeens luciorubeens requested review from j-a-m-l and alexbarnsley Jan 15, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jan 15, 2019

Codecov Report

Merging #965 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #965   +/-   ##
========================================
  Coverage    38.81%   38.81%           
========================================
  Files          196      196           
  Lines         4833     4833           
  Branches       945      942    -3     
========================================
  Hits          1876     1876           
  Misses        2838     2838           
  Partials       119      119

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7326f3b...44b79de. Read the comment docs.

@alexbarnsley
Copy link
Member

left a comment

image

I presume this is expected in dev? :trollface:

@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Jan 15, 2019

My approval is based on the above being correct. Merge if you're happy @luciorubeens

@luciorubeens luciorubeens merged commit d851c94 into develop Jan 15, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@luciorubeens luciorubeens deleted the feat/release-filename branch Jan 15, 2019

@luciorubeens luciorubeens referenced this pull request Jan 16, 2019
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.