Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: db migration system #967

Merged
merged 10 commits into from Jan 30, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Jan 15, 2019

Proposed changes

This PR allows executing migrations when the version of the app changes.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

To test this, you could add new migrations and change the package.json version to see if / how migrations are applied.

@codecov-io

This comment has been minimized.

Copy link

commented Jan 17, 2019

Codecov Report

Merging #967 into develop will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #967      +/-   ##
===========================================
+ Coverage     39.3%   39.43%   +0.12%     
===========================================
  Files          202      204       +2     
  Lines         5098     5127      +29     
  Branches      1001     1007       +6     
===========================================
+ Hits          2004     2022      +18     
- Misses        2975     2983       +8     
- Partials       119      122       +3
Impacted Files Coverage Δ
.../renderer/store/plugins/vuex-persist-migrations.js 100% <100%> (ø)
src/renderer/store/index.js 87.5% <100%> (+7.5%) ⬆️
src/renderer/store/modules/app.js 35.29% <100%> (+13.86%) ⬆️
...erer/store/migrations/2.2.0 - initial migration.js 100% <100%> (ø)
src/renderer/store/modules/peer.js 68.69% <0%> (-3.74%) ⬇️
src/renderer/services/client.js 65.99% <0%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7660fb...f0d0408. Read the comment docs.

j-a-m-l added some commits Jan 21, 2019

@luciorubeens luciorubeens merged commit 683a76d into develop Jan 30, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@luciorubeens luciorubeens deleted the db-migrations branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.