Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip position of truncated address #970

Merged
merged 1 commit into from Jan 16, 2019

Conversation

@alexbarnsley
Copy link
Member

commented Jan 16, 2019

Proposed changes

image

fixes this:
image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

commented Jan 16, 2019

Codecov Report

Merging #970 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #970   +/-   ##
========================================
  Coverage    38.89%   38.89%           
========================================
  Files          196      196           
  Lines         4833     4833           
  Branches       945      942    -3     
========================================
  Hits          1880     1880           
  Misses        2835     2835           
  Partials       118      118
Impacted Files Coverage Δ
src/renderer/components/Wallet/WalletAddress.vue 53.84% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a85da7...c551be9. Read the comment docs.

@luciorubeens luciorubeens merged commit 487d3c9 into develop Jan 16, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@luciorubeens luciorubeens deleted the fix/address-tooltip branch Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.