Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display the right error message on the fee slider #978

merged 1 commit into from Jan 16, 2019


Copy link

commented Jan 16, 2019

Proposed changes

The "Advanced" option of the fee slider displays the wrong message when the introduced value is 10 times bigger than the default maximum fee.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)


  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

This comment has been minimized.

Copy link

commented Jan 16, 2019

Codecov Report

Merging #978 into develop will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #978      +/-   ##
- Coverage    38.85%   38.76%   -0.09%     
  Files          196      196              
  Lines         4839     4839              
  Branches       945      945              
- Hits          1880     1876       -4     
- Misses        2841     2844       +3     
- Partials       118      119       +1
Impacted Files Coverage Δ
src/renderer/components/Input/InputCurrency.vue 39.43% <100%> (ø) ⬆️
src/renderer/store/modules/peer.js 69.37% <0%> (-1.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2334d2f...fde5dfe. Read the comment docs.

@alexbarnsley alexbarnsley merged commit 2c25cfa into develop Jan 16, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!

@alexbarnsley alexbarnsley deleted the fix-advanced-fee-slider branch Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.