Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashboard duplicate transaction refresh #979

Merged
merged 2 commits into from Jan 17, 2019

Conversation

@alexbarnsley
Copy link
Member

commented Jan 16, 2019

Proposed changes

Every time a wallet was updated in synchronizer, it was triggering the Dashboard to fetch transactions. This happened for each wallet change. For example, 4 wallets - each change individually caused the dashboard to fetch transactions for those 4 wallets. This was resulting in 4 unnecessary API requests since the synchronizer already fetches transactions for those wallets.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

commented Jan 17, 2019

Codecov Report

Merging #979 into develop will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #979      +/-   ##
===========================================
- Coverage    38.57%   38.55%   -0.02%     
===========================================
  Files          198      198              
  Lines         4905     4915      +10     
  Branches       961      961              
===========================================
+ Hits          1892     1895       +3     
- Misses        2895     2902       +7     
  Partials       118      118
Impacted Files Coverage Δ
...rer/components/Dashboard/DashboardTransactions.vue 72.41% <50%> (-22.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6c4a1a...ecb0d16. Read the comment docs.

@luciorubeens luciorubeens merged commit fd35475 into develop Jan 17, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@luciorubeens luciorubeens deleted the fix/dashboard-duplicate-wallet-update branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.