Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: new background for profile edition page #984

Merged
merged 5 commits into from Jan 17, 2019

Conversation

@luciorubeens
Copy link
Member

commented Jan 17, 2019

Proposed changes

Fit to Oleg's new design.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
@codecov-io

This comment has been minimized.

Copy link

commented Jan 17, 2019

Codecov Report

Merging #984 into develop will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #984      +/-   ##
===========================================
- Coverage    38.58%   38.57%   -0.02%     
===========================================
  Files          198      198              
  Lines         4903     4905       +2     
  Branches       961      958       -3     
===========================================
  Hits          1892     1892              
- Misses        2893     2895       +2     
  Partials       118      118
Impacted Files Coverage Δ
src/renderer/pages/Profile/ProfileEdition.vue 8.88% <83.33%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c145851...17c02ea. Read the comment docs.

luciorubeens and others added some commits Jan 17, 2019

Merge branch 'feat/new-profile-edition' of github.com:ArkEcosystem/de…
…sktop-wallet into feat/new-profile-edition

@j-a-m-l j-a-m-l changed the title feat: new profile edition page feat: new background for profile edition page Jan 17, 2019

@j-a-m-l j-a-m-l changed the title feat: new background for profile edition page improvement: new background for profile edition page Jan 17, 2019

@j-a-m-l j-a-m-l merged commit c6c4a1a into develop Jan 17, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@j-a-m-l j-a-m-l deleted the feat/new-profile-edition branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.