New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong derivation source of wallet address #231

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
2 participants
@Nigui
Copy link
Contributor

Nigui commented Jan 9, 2019

Proposed changes

Fix mistake in documentation data Models.
Wallet address is derived from public key and not private key (source)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

@faustbrian faustbrian merged commit d8171d0 into ArkEcosystem:master Jan 10, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment