Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix Cpp Demo Example #309

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
4 participants
@sleepdefic1t
Copy link
Contributor

sleepdefic1t commented Mar 11, 2019

Proposed changes

This PR fixes the Cpp Demo examples.

The connection.api.transactions.send() method requires a string-type be passed in.

This fix adds a string buffer for the transactions object to be passed to the transactions.send() method.

Types of changes

  • Docs (documentation only changes)

Checklist

docs: fix cpp demo example
tx.send needs string object

@faustbrian faustbrian merged commit 33f3ce2 into ArkEcosystem:master Mar 11, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
@sleepdefic1t

This comment has been minimized.

Copy link
Contributor Author

sleepdefic1t commented Mar 11, 2019

Also...
Props to @pj in ARK Eco Slack for finding this error.

@pj

This comment has been minimized.

Copy link

pj commented Mar 11, 2019

Wrong @pj :-)

@sleepdefic1t sleepdefic1t deleted the sleepdefic1t:docs/fix-cpp-demo branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.