Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add styles to details/summary #371

Merged
merged 2 commits into from Apr 10, 2019

Conversation

Projects
None yet
3 participants
@dated
Copy link
Contributor

dated commented Apr 9, 2019

Proposed changes

Adds some styles so that the <details> blocks can be identified as expandable more easily. This PR also adds a border-radius to the tip/danger/warning boxes.

For reference: https://docs.ark.io/guidebook/guides/desktop.html

screencapture-localhost-8080-guidebook-guides-desktop-html-2019-04-09-14_13_27

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 9, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 10, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 48d78c7 into ArkEcosystem:master Apr 10, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 10, 2019

Your pull request has been merged and marked as tier 3. It will earn you $25 USD.

@dated dated deleted the dated:details-styles branch Apr 10, 2019

@dated

This comment has been minimized.

Copy link
Contributor Author

dated commented Apr 10, 2019

The esp32 and esp8266 documentations contain nested <detail> blocks. This certainly isn't ideal and those pages should probably be reworked, as imho the general documentation style and structure doesn't align to well with the rest of the docs.

For reference https://docs.ark.io/tutorials/iot/boards/esp32-adafruit/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.