Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add gsod to sidebar #397

Merged
merged 2 commits into from May 8, 2019

Conversation

Projects
None yet
3 participants
@dated
Copy link
Contributor

commented May 8, 2019

Proposed changes

Adds the GSoD documentation to the sidebar.

https://docs.ark.io/guidebook/contribution-guidelines/gsod.html currently shows the ToC twice, and the sidebar is not working. I was however unable to reproduce the error locally @faustbrian.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe: chore

Checklist

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@faustbrian

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

I am aware of the ToC issue but it only occurs in production files after yarn build is ran, haven't had the time yet to really look into it.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 8, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit af37825 into ArkEcosystem:master May 8, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Your pull request has been merged and marked as tier 6. It will earn you $1 USD.

@dated dated deleted the dated:chore/gsod-sidebar branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.