Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpp): correct namespace capitalization #442

Conversation

Projects
None yet
3 participants
@sleepdefic1t
Copy link
Contributor

commented Jul 1, 2019

Current docs show the C++ SDKs' top-level namespace as ARK where it should be Ark.
Namespaces are case-sensitive, so this is incorrect.

This PR changes ARK to Ark only in relevant doc and code examples pertaining to the C++ SDK's.

What kind of change does this PR introduce?

  • Documentation

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [n/a] It's submitted to the develop branch, not the master branch
  • All tests are passing
  • [n/a] New/updated tests are included
fix(cpp): restore namespaces formatting
Current docs show the C++ SDKs' top-level namespace as `ARK` where it should read as `Ark`.
Namespaces are case-sensitive, so this is incorrect.

This PR changes `ARK` for `Ark` only in relevant doc and code examples pertaining to the C++ SDK's.

@sleepdefic1t sleepdefic1t marked this pull request as ready for review Jul 1, 2019

@faustbrian faustbrian merged commit cdf7a3b into ArkEcosystem:master Jul 2, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.