Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated a deprecated ssl directive in secure.md #472

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@Sokom141
Copy link
Contributor

commented Sep 10, 2019

The "ssl" directive is deprecated in NGINX, now the "listen 443 ssl" is used instead.

A summary of what changes this PR introduces and why they were made.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • [x ] Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • [ x] No

Does this PR release a new version?

  • Yes
  • [ x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ x] It's submitted to the develop branch, not the master branch
  • [x ] All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
Updated a deprecated ssl directive in secure.md
The "ssl" directive is deprecated in NGINX, now the "listen 443 ssl" is used instead.
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian changed the title Updated a deprecated ssl directive in secure.md docs: Updated a deprecated ssl directive in secure.md Sep 11, 2019

@faustbrian faustbrian merged commit dbb6105 into ArkEcosystem:master Sep 11, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

Your pull request has been merged. Thank you for your contribution to the ARK Ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.